add jte-kotlin if ktolin #2604
add jte-kotlin if ktolin #2604
Conversation
| generatorContext.addDependency(MicronautDependencyUtils.viewsDependency() | ||
| .artifactId(ARTIFACT_ID_MICRONAUT_VIEWS_JTE) | ||
| .compile()); | ||
| if (generatorContext.getLanguage() == Language.KOTLIN) { |
There was a problem hiding this comment.
Why are both dependencies with a scope compile? I would expect the view dependency as implementation and the other as compileOnly - in Gradle terminology
There was a problem hiding this comment.
I changed it to compileOnly in the module micronaut-projects/micronaut-views#877
There was a problem hiding this comment.
Yes, but my understanding is that the dependency is only needed as a compile plugin so in starter it should be added as compile only too.
Are you sure we need to have that dependency in Micronaut Views?
There was a problem hiding this comment.
Are you sure we need to have that dependency in Micronaut Views?
What dependency?
There was a problem hiding this comment.
You wrote that you changed it to compileOnly
There was a problem hiding this comment.
Regarding this PR, it's a bit strange to have micronaut-views and kotlin with the same scope
See: micronaut-projects/micronaut-views#876