Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/barva #3772

Merged
merged 1 commit into from
Oct 29, 2023
Merged

media-sound/barva #3772

merged 1 commit into from
Oct 29, 2023

Conversation

Goldsrc233
Copy link
Contributor

note: this is the legacy edition that uses C instead of python

@github-actions

This comment has been minimized.

@Goldsrc233 Goldsrc233 closed this Oct 28, 2023
@Goldsrc233 Goldsrc233 reopened this Oct 28, 2023
@Goldsrc233
Copy link
Contributor Author

按错了

@github-actions

This comment has been minimized.

@liangyongxiang
Copy link
Collaborator

git commit 可以考虑用 pkgdev commit 来生成

@liangyongxiang
Copy link
Collaborator

git reset --soft HEAD^
pkgdev commit

@Goldsrc233
Copy link
Contributor Author

git reset --soft HEAD^
pkgdev commit

感谢

@github-actions

This comment has been minimized.

@liangyongxiang
Copy link
Collaborator

pkgcheck checks passed but with something can be improved!

* pkgcheck 0.10.25

* the corresponding _**::gentoo**_ commit: [gentoo-mirror/gentoo@55417c8](https://github.com/gentoo-mirror/gentoo/commit/55417c8746ae791fc6cfbbdc8e05b084a4361f76)

QA Results:

media-sound/barva
  MissingRemoteId: missing <remote-id type="github">Kharacternyk/barva</remote-id> (inferred from URI 'https://github.com/Kharacternyk/barva')

🔍 QA Keywords Explanation

这个警告,可以添加metadata.xml文件,并且写好remote-id 来处理

@liangyongxiang
Copy link
Collaborator

修改好之后,可以在本地ebuild目录运行 pkgcheck scan确认没有警告

@Universebenzene
Copy link
Contributor

@liangyongxiang 话说pkgcheck现在发现没有metadata.xml的时候是只报warning不报error?

@liangyongxiang
Copy link
Collaborator

@Universebenzene 什么都不会报。上面是缺github remote id才有QA

@github-actions

This comment has been minimized.

@Universebenzene
Copy link
Contributor

@github-actions[bot] ?这x权限是咋加上去的

@github-actions

This comment has been minimized.

@liangyongxiang
Copy link
Collaborator

@github-actions[bot] @Universebenzene

media-sound/barva: replace symlink to /usr/bin/cc to the actual compiler
@github-actions
Copy link

✔️ pkgcheck checks passed

@Goldsrc233
Copy link
Contributor Author

原编译使用/usr/bin/cc的symlink这里替换为tc-getCC

@liangyongxiang
Copy link
Collaborator

先合并了,有问题后面再修复

@liangyongxiang liangyongxiang merged commit 28b41a7 into microcai:master Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants