Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a switch to enable autolinking of links. #386

Closed
wants to merge 1 commit into from

Conversation

appel
Copy link

@appel appel commented Oct 25, 2022

As discussed in #326. It's not pretty but it seems to work.

As discussed in michelf#326. It's not pretty but it seems to work.
@edent
Copy link

edent commented Sep 3, 2024

I like this, but I think it breaks if there's a link inside another link.

For example:

Markdown [Visit https://example.com](https://example.com)
HTML <a href="https://example.com">Visit https://example.com</a>

Is rendered as:

<a href="https://example.com">Visit <a href="https://example.com">https://example.com</a></a>

@appel
Copy link
Author

appel commented Sep 3, 2024

Hey edent, thanks for your comment. Honestly, I can't remember if I tested this at the time, but I agree that that would be a bit of an issue. :) I don't think my PR really went anywhere and I have since moved on to a different MD implementation, so I won't be able to look into this, unfortunately.

@appel appel closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants