-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new feature to the expand option. Its now possible to choose if ... #89
base: master
Are you sure you want to change the base?
Conversation
…if the top (main) panel is shifted or not and the the message tray no longer collides with the dock.
Thanks for your contribution. I'll try to have look at it in the next weeks.
|
Works fine on Fedora 20 with GNOME Shell 3.10.3 having the panel always present and maximed to full height. Would be really nice to have it merged! |
Thanks for letting me know that it works. I haven't had time to test it I apology with @p0intR for the long delay taking into consideration his |
I finally tested the patch. There's a minor problem. The panel shouldn't shift if the dash is not maximized, i.e. the option should not have any effect nor should be settable when the extended always visible options are not set as well. |
First of all, thank you for testing my changes! |
eb77486
to
6a6d4e4
Compare
...the top (main) panel is shifted or not and the the message tray no longer collides with the dock.
Made this addition because I like the way the dock presents itself expended, but hated the way it shifted that top bar (margin). With this changes the user can change that behaviour. Also the dock no longer collides with the message tray at the bottom by setting the margin on the tray if it's expended.
I hope this will help you making this extension even better!