Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new feature to the expand option. Its now possible to choose if ... #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p0intR
Copy link

@p0intR p0intR commented Dec 18, 2013

...the top (main) panel is shifted or not and the the message tray no longer collides with the dock.

Made this addition because I like the way the dock presents itself expended, but hated the way it shifted that top bar (margin). With this changes the user can change that behaviour. Also the dock no longer collides with the message tray at the bottom by setting the margin on the tray if it's expended.

I hope this will help you making this extension even better!

…if the top (main) panel is shifted or not and the the message tray no longer collides with the dock.
@micheleg
Copy link
Owner

Thanks for your contribution. I'll try to have look at it in the next weeks.
On 18 Dec 2013 02:26, "p0intR" [email protected] wrote:

...the top (main) panel is shifted or not and the the message tray no
longer collides with the dock.

Made this addition because I like the way the dock presents itself
expended, but hated the way it shifted that top bar (margin). With this
changes the user can change that behaviour. Also the dock no longer
collides with the message tray at the bottom by setting the margin on the
tray if it's expended.

I hope this will help you making this extension even better!

You can merge this Pull Request by running

git pull https://github.com/p0intR/dash-to-dock master

Or view, comment on, or merge it at:

#89
Commit Summary

  • Added a new feature to the expand option. Its now possible to choose
    if the top (main) panel is shifted or not and the the message tray no
    longer collides with the dock.

File Changes

Patch Links:

@oktayacikalin
Copy link

Works fine on Fedora 20 with GNOME Shell 3.10.3 having the panel always present and maximed to full height. Would be really nice to have it merged!

@micheleg
Copy link
Owner

micheleg commented Mar 4, 2014

Thanks for letting me know that it works. I haven't had time to test it
myself. I hope to be able to finally do it just after I update the
extension for 3.12.

I apology with @p0intR for the long delay taking into consideration his
contribution.

@micheleg
Copy link
Owner

I finally tested the patch. There's a minor problem. The panel shouldn't shift if the dash is not maximized, i.e. the option should not have any effect nor should be settable when the extended always visible options are not set as well.

@p0intR
Copy link
Author

p0intR commented Mar 14, 2014

First of all, thank you for testing my changes!
I always use the dash maximized, so this problem never occurred to me.. nice testing on my side -.-'
I'll take this improvements in consideration an will upload a revised version soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants