Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated "St.ScrollView.[hv]scroll" property #2185

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

K1ngjulien
Copy link
Contributor

no more deprecation warnings on my machine :)

see: #2159

@K1ngjulien
Copy link
Contributor Author

ah damn i'm not sure this is backwards compatible with gnome 45. no clue how to do that 😅

@K1ngjulien
Copy link
Contributor Author

its just JavaScript right? can i just check if scrollView.hadjustment === undefined and then fall back to the old way of accessing it?

or is there a better way of doing things?
(sorry, I'm pretty new to writing gnome extensions)

@K1ngjulien
Copy link
Contributor Author

@vanvugt @sergio-costas i think that should do it now?

dash.js Outdated Show resolved Hide resolved
@K1ngjulien K1ngjulien force-pushed the master branch 2 times, most recently from 751f5cf to 736e769 Compare April 1, 2024 21:41
@vanvugt
Copy link
Collaborator

vanvugt commented Apr 2, 2024

Checks failed:

/home/runner/work/dash-to-dock/dash-to-dock/dash.js
  1142:60  error  Block must not be padded by blank lines  padded-blocks
  1147:80  error  Missing semicolon                        semi
  1148:80  error  Missing semicolon                        semi

@K1ngjulien
Copy link
Contributor Author

should be fixed now

@vanvugt vanvugt merged commit 44a4726 into micheleg:master Apr 2, 2024
1 check passed
@vanvugt
Copy link
Collaborator

vanvugt commented Apr 2, 2024

Thanks.

@sergio-costas
Copy link
Collaborator

Thanks!!!!

@K1ngjulien
Copy link
Contributor Author

you're welcome :)
sooo ready for gnome 46 release now? :P

@Aqua1ung
Copy link

Aqua1ung commented Apr 3, 2024

sooo ready for gnome 46 release now? :P

C'mon guys, put it up there already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants