docking: fix window picker space for multi-monitor environments #2158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to fix #2154.
This PR:
_computeWorkspacesBoxForState
. It looks like that this function only cares about the workspace on primary monitor, as original GNOME dock is in primary one.WorkspacesView.SecondaryMonitorDisplay._getWorkspacesBoxForState
. This function is similar to_computeWorkspacesBoxForState
, and looks like the correct function to hook without glitches.In
_getWorkspacesBoxForState
:maybeAdjustBoxSize
is not reused as the workspace in secondary monitor does not have things likesearchBox
.Only bottom dock is handled, as it looks like nothing is wrong with docks positioned at left/right, and... I'm not sure how dock at top shall look like.
preferredHeight
might be too large here:But there's no
this.spacing
insideSt.Widget
:(And this only fixes the window picker part. A similar bug in multi-monitor environments, when "Workspaces on primary display only" is chosen, still exists when overview state is app grid -- but this could be triggered even without any extensions and thus a gnome-shell bug at present (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5316), though the space between dock and workspace is still too small.