Skip to content

Commit

Permalink
utils: Use an extra parameter for property injector constructor
Browse files Browse the repository at this point in the history
By adding parameters in commit 611690c we ended up hiding the base
object constructor parameter, and so the support for automatic
disconnection on parent object destruction.

Fixes: #2297
  • Loading branch information
3v1n0 committed Oct 3, 2024
1 parent 5e6ae8f commit b815d68
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion appIconsDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export class AppIconsDecorator {
constructor() {
this._signals = new Utils.GlobalSignalsHandler();
this._methodInjections = new Utils.InjectionsHandler();
this._propertyInjections = new Utils.PropertyInjectionsHandler({allowNewProperty: true});
this._propertyInjections = new Utils.PropertyInjectionsHandler(
null, {allowNewProperty: true});
this._indicators = new Set();

this._patchAppIcons();
Expand Down
4 changes: 2 additions & 2 deletions utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,8 @@ export class VFuncInjectionsHandler extends BasicHandler {
* and restored
*/
export class PropertyInjectionsHandler extends BasicHandler {
constructor(params) {
super();
constructor(parentObject, params) {
super(parentObject);
this._params = params;
}

Expand Down

0 comments on commit b815d68

Please sign in to comment.