Skip to content

Commit

Permalink
Code review fixes
Browse files Browse the repository at this point in the history
Use `AudioDeviceSetupWidget` instead of `QObject` to translate "[System
Default]".

Fix copy/paste error in comment.
  • Loading branch information
michaelgregorius committed Aug 10, 2024
1 parent 459fe8a commit f78e147
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/audio/AudioSdl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void AudioSdl::sdlInputAudioCallback(Uint8 *_buf, int _len) {

#endif

QString AudioSdl::setupWidget::s_systemDefaultDevice = QObject::tr("[System Default]");
QString AudioSdl::setupWidget::s_systemDefaultDevice = AudioDeviceSetupWidget::tr("[System Default]");

AudioSdl::setupWidget::setupWidget( QWidget * _parent ) :
AudioDeviceSetupWidget( AudioSdl::name(), _parent )
Expand Down Expand Up @@ -333,7 +333,7 @@ void AudioSdl::setupWidget::saveSettings()
const auto currentPlaybackDevice = m_playbackDeviceComboBox->currentText();
if (currentPlaybackDevice == s_systemDefaultDevice)
{
// Represent the default input device with an empty string
// Represent the default playback device with an empty string
ConfigManager::inst()->setValue(SectionSDL, PlaybackDeviceSDL, "");
}
else if (!currentPlaybackDevice.isEmpty())
Expand Down

0 comments on commit f78e147

Please sign in to comment.