Skip to content

Commit

Permalink
Use LmmsComboBox in Microtuner config
Browse files Browse the repository at this point in the history
Replace the `ComboBox` that was used in `MicrotunerConfig` with an `LmmsComboBox`. This disables the automation of these boxes which led to crashes.
  • Loading branch information
michaelgregorius committed May 10, 2024
1 parent 3926716 commit 7c6d773
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/gui/MicrotunerConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include <QRegularExpression>
#include <QTextStream>

#include "ComboBox.h"
#include "LmmsComboBox.h"
#include "embed.h"
#include "Engine.h"
#include "FileDialog.h"
Expand Down Expand Up @@ -91,8 +91,7 @@ MicrotunerConfig::MicrotunerConfig() :
{
m_scaleComboModel.addItem(QString::number(i) + ": " + Engine::getSong()->getScale(i)->getDescription());
}
auto scaleCombo = new ComboBox();
scaleCombo->setModel(&m_scaleComboModel);
auto scaleCombo = new LmmsComboBox(this, &m_scaleComboModel);
microtunerLayout->addWidget(scaleCombo, 1, 0, 1, 2);
connect(&m_scaleComboModel, &ComboBoxModel::dataChanged, [=] {updateScaleForm();});

Expand Down Expand Up @@ -129,8 +128,7 @@ MicrotunerConfig::MicrotunerConfig() :
{
m_keymapComboModel.addItem(QString::number(i) + ": " + Engine::getSong()->getKeymap(i)->getDescription());
}
auto keymapCombo = new ComboBox();
keymapCombo->setModel(&m_keymapComboModel);
auto keymapCombo = new LmmsComboBox(this, &m_keymapComboModel);
microtunerLayout->addWidget(keymapCombo, 1, 2, 1, 2);
connect(&m_keymapComboModel, &ComboBoxModel::dataChanged, [=] {updateKeymapForm();});

Expand Down

0 comments on commit 7c6d773

Please sign in to comment.