Add SampleClip::hasSampleFileLoaded

Add the method `SampleClip::hasSampleFileLoaded` and remove some comments.

include/SampleClip.h

@@ -57,6 +57,7 @@ class SampleClip : public Clip
 	void changeLength( const TimePos & _length ) override;
 	void changeLengthToSampleLength();
 	const QString& sampleFile() const;
+	bool hasSampleFileLoaded(const QString & filename) const;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override;
 	void loadSettings( const QDomElement & _this ) override;

src/core/SampleClip.cpp

@@ -125,6 +125,11 @@ const QString& SampleClip::sampleFile() const
 	return m_sample.sampleFile();
 }
 
+bool SampleClip::hasSampleFileLoaded(const QString & filename) const
+{
+	return m_sample.sampleFile() == filename;
+}
+
 void SampleClip::setSampleBuffer(std::shared_ptr<const SampleBuffer> sb)
 {
 	{

src/gui/clips/SampleClipView.cpp

@@ -180,20 +180,17 @@ void SampleClipView::mouseReleaseEvent(QMouseEvent *_me)
 
 void SampleClipView::mouseDoubleClickEvent( QMouseEvent * )
 {
-	QString af = SampleLoader::openAudioFile();
+	const QString selectedAudioFile = SampleLoader::openAudioFile();
 
-	// Don't do anything if no file is loaded
-	if (af.isEmpty()) { return; }
+	if (selectedAudioFile.isEmpty()) { return; }
 
-	if (af == m_clip->m_sample.sampleFile())
+	if (m_clip->hasSampleFileLoaded(selectedAudioFile))
 	{
-		// Don't reload the same file again. Just reset the size.
 		m_clip->changeLengthToSampleLength();
 	}
 	else
 	{
-		// Load the new file and set it for the clip
-		auto sampleBuffer = SampleLoader::createBufferFromFile(af);
+		auto sampleBuffer = SampleLoader::createBufferFromFile(selectedAudioFile);
 		if (sampleBuffer != SampleBuffer::emptyBuffer())
 		{
 			m_clip->setSampleBuffer(sampleBuffer);