Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-creates a release when master branch is updated #6

Closed
wants to merge 1 commit into from

Conversation

R-Y-M-R
Copy link

@R-Y-M-R R-Y-M-R commented Jan 2, 2025

Feature: build-and-release Workflow

This pull request includes a github action (and requirements for said action) which tries to tag and Release a .jar automatically when new code is pushed to the master branch. This will allow users to download the latest .jar file directly and use it as a library if they want. This also addresses #5 as instead of waiting for a response from jitpack, they can use a local .jar.

Added requirements:

  • fatJar gradle task
  • gradle wrapper

Testing

  • I tested adding the .jar as a library to a project and using the webhooks. It seemed to work fine.

- fatJar
- gradlew
@R-Y-M-R R-Y-M-R marked this pull request as ready for review January 2, 2025 23:00
@micartey micartey closed this Jan 5, 2025
Repository owner locked and limited conversation to collaborators Jan 5, 2025
Repository owner unlocked this conversation Jan 5, 2025
Repository owner locked and limited conversation to collaborators Jan 5, 2025
Repository owner unlocked this conversation Jan 5, 2025
@micartey
Copy link
Owner

micartey commented Jan 5, 2025

My de-compiler played a joke on me and falsely showed obfuscated code while it wasn't...
After checking the checksum and compare it with an official release of gradle I could confirm that the wrapper jar is indeed official.

Regardless, using local jars is bad practice and shall not be supported!

Jitpack normally doesn't have those timeout issues and I don't expect them to stay.
Nevertheless, you only need to download it once - afterward, the jar is cached locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants