Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #171, this adds
xDomainSort
,yDomainSort
,zDomainSort
andrDomainSort
that will kick in when the scale is ordinal.This is a technically a breaking change because it changes the signature of the exported helper functioncalcUniques
. . Users that aren't importing that function separately will be fineCurrently the third argument is an object with the option of
{ sort: true }
. This PR additionally accepts per-field entries:The default is unsorted when using the function directly but sorts when used in your chart.
Tasks