Fix panic on NullTime.UnmarshalJSON #73

khoden · 2017-08-03T08:19:01Z

type WithDate struct {
	Time dat.NullTime `json:"time"`
}

func TestParseNumberAsDate(t *testing.T) {
	data := `{"time":5}`
	result := &WithDate{}
	json.Unmarshal([]byte(data), result) // PANIC!
}

```json type WithDate struct { Time dat.NullTime `json:"time"` } func TestParseNumberAsDate(t *testing.T) { data := `{"time":5}` result := &WithDate{} json.Unmarshal([]byte(data), result) // PANIC! } ```

C-Pro

Seems legit

JelteF · 2017-08-15T09:29:46Z

This test should probably be added to the actual tests as well.

khoden · 2017-08-25T06:50:44Z

Please, accept

Fix panic on NullTime.UnmarshalJSON

76397f5

```json type WithDate struct { Time dat.NullTime `json:"time"` } func TestParseNumberAsDate(t *testing.T) { data := `{"time":5}` result := &WithDate{} json.Unmarshal([]byte(data), result) // PANIC! } ```

C-Pro approved these changes Aug 3, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix panic on NullTime.UnmarshalJSON #73

Fix panic on NullTime.UnmarshalJSON #73

khoden commented Aug 3, 2017 •

edited

Loading

C-Pro left a comment

JelteF commented Aug 15, 2017

khoden commented Aug 25, 2017

Fix panic on NullTime.UnmarshalJSON #73

Are you sure you want to change the base?

Fix panic on NullTime.UnmarshalJSON #73

Conversation

khoden commented Aug 3, 2017 • edited Loading

C-Pro left a comment

Choose a reason for hiding this comment

JelteF commented Aug 15, 2017

khoden commented Aug 25, 2017

khoden commented Aug 3, 2017 •

edited

Loading