Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for building using CMake #249

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add initial support for building using CMake #249

wants to merge 3 commits into from

Commits on Oct 9, 2023

  1. Add initial support for building using CMake

    @DanShaders
    DanShaders committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ca88976 View commit details
    Browse the repository at this point in the history

  2. Fix compilation with modern C++ standards

    @DanShaders
    DanShaders committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ab7c254 View commit details
    Browse the repository at this point in the history

  3. Fix ODR violations in tests 

    CMake builds all tests into a single executable. So, naming these two
classes the same is an ODR violation, which also causes segmentation
fault on my machine when I try to run tests.

With this patch, test executable do not crash anymore. However, there
are still 13 failing tests, which require further investigation.
    @DanShaders
    DanShaders committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9e7b3a4 View commit details
    Browse the repository at this point in the history