-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetExceptionBreakpoint Optional Args #1378
base: master
Are you sure you want to change the base?
Conversation
Oh yeah! 'filterOptions' is required for Unity debugger. It would be great to merge this PR. |
It will be some time before I get to this, because I'll want to make sure the API fits with what I have in mind for #1388 and also see how to deal with #494 . Before that I won't be making any other public API changes to these methods. In the meantime you could |
@mfussenegger Yes, I understand. You are absolutely right. For now, I will continue to modify session.lua locally. Maybe this issue will be solved in the future. |
Sounds good. I am happy to come back and refactor this PR is need be after you make any major changes for #1388 and/or #494.
Agreed, they should adhere to the spec. I tried their support avenues, and never heard back. I assume I never will, but was worth a shot... |
@Erifirin I have my fork public and plan to keep it up while these changes aren't in nvim-dap. Feel free to use it if it saves you time over manually updating session.lua. Cheers. |
I did so. At least they promised to fix the bug in the next version of visualstudiotoolsforunity.vstuc. |
In nvim-dap, set_exception_breakpoints() exposes one of two optional args in the DAP spec (ExceptionOptions), and it is always nil. This PR adds the other optional arg (ExceptionFilterOptions) and exposes both optional args in defaults.
This allows for non nil definitions of both optional args in the default table if needed/desired, otherwise they will default to nil.
Tested with debugpy, codelldb, and the Unity debugger.