feat: improved html check in serializiers.

src/Serializer/KuveytPosSerializer.php

@@ -20,6 +20,8 @@
 
 class KuveytPosSerializer implements SerializerInterface
 {
+    use SerializerUtilTrait;
+
     /** @var string[] */
     private array $nonPaymentTransactions = [
         PosInterface::TX_TYPE_REFUND,
@@ -88,16 +90,6 @@ public function decode(string $data, string $txType): array
         }
     }
 
-    /**
-     * @param string $str
-     *
-     * @return bool returns true if string is a HTML document.
-     */
-    private function isHTML(string $str): bool
-    {
-        return $str !== \strip_tags($str);
-    }
-
     /**
      * Diger Gateway'lerden farkli olarak bu gateway HTML form olan bir response doner.
      * Kutupahenin islem akisina uymasi icin bu HTML form verilerini array'e donusturup, kendimiz post ediyoruz.

src/Serializer/PayFlexCPV4PosSerializer.php

@@ -14,6 +14,8 @@
 
 class PayFlexCPV4PosSerializer implements SerializerInterface
 {
+    use SerializerUtilTrait;
+
     private Serializer $serializer;
 
     public function __construct()
@@ -78,17 +80,4 @@ public function decode(string $data, ?string $txType = null): array
 
         throw $notEncodableValueException;
     }
-
-    /**
-     * must be called after making sure that $str does not contain XML string.
-     * Because for XML strings it will also return true.
-     *
-     * @param string $str
-     *
-     * @return bool
-     */
-    private function isHTML(string $str): bool
-    {
-        return $str !== \strip_tags($str);
-    }
 }

src/Serializer/PayFlexV4PosSerializer.php

@@ -14,6 +14,8 @@
 
 class PayFlexV4PosSerializer implements SerializerInterface
 {
+    use SerializerUtilTrait;
+
     private Serializer $serializer;
 
     public function __construct()
@@ -75,9 +77,4 @@ public function decode(string $data, ?string $txType = null): array
             throw $notEncodableValueException;
         }
     }
-
-    private function isHTML(string $str): bool
-    {
-        return $str !== \strip_tags($str);
-    }
 }

src/Serializer/SerializerUtilTrait.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ * @license MIT
+ */
+
+namespace Mews\Pos\Serializer;
+
+/**
+ * Serializer utility methods.
+ */
+trait SerializerUtilTrait
+{
+    /**
+     * @param string $string
+     *
+     * @return bool
+     */
+    private function isHTML(string $string): bool
+    {
+        if ('' === \trim($string)) {
+            return false;
+        }
+
+        // Suppress errors for invalid HTML
+        $previousLibxmlState = \libxml_use_internal_errors(true);
+
+        // Create a new DOMDocument
+        $dom = new \DOMDocument();
+
+        // Attempt to load the string as HTML
+        $isValidHTML = $dom->loadHTML($string, LIBXML_NOERROR | LIBXML_NOWARNING);
+
+        // Clear any libxml errors
+        \libxml_clear_errors();
+
+        // Restore the previous libxml error handling state
+        \libxml_use_internal_errors($previousLibxmlState);
+
+        // Check if the string has recognizable HTML elements
+        return $isValidHTML && $dom->getElementsByTagName('html')->length > 0;
+    }
+}

src/Serializer/VakifKatilimPosSerializer.php

@@ -18,6 +18,8 @@
 
 class VakifKatilimPosSerializer implements SerializerInterface
 {
+    use SerializerUtilTrait;
+
     private Serializer $serializer;
 
     public function __construct()
@@ -66,16 +68,6 @@ public function decode(string $data, string $txType): array
         }
     }
 
-    /**
-     * @param string $str
-     *
-     * @return bool returns true if string is a HTML document.
-     */
-    private function isHTML(string $str): bool
-    {
-        return $str !== \strip_tags($str);
-    }
-
     /**
      * Diger Gateway'lerden farkli olarak bu gateway HTML form olan bir response doner.
      * Kutupahenin islem akisina uymasi icin bu HTML form verilerini array'e donusturup, kendimiz post ediyoruz.