test coverage and refactor exception throws

mewebstudio · Apr 1, 2024 · 376c8f7 · 376c8f7
1 parent f7ebd46
commit 376c8f7
Show file tree

Hide file tree

Showing 19 changed files with 3,007 additions and 43 deletions.
diff --git a/src/Gateways/InterPos.php b/src/Gateways/InterPos.php
@@ -119,7 +119,9 @@ public function make3DPayPayment(Request $request, array $order, string $txType)
      */
     public function make3DHostPayment(Request $request, array $order, string $txType): PosInterface
     {
-        return $this->make3DPayPayment($request, $order, $txType);
+        $this->response = $this->responseDataMapper->map3DHostResponseData($request->request->all(), $txType, $order);
+
+        return $this;
     }
 
     /**

diff --git a/src/Gateways/KuveytPos.php b/src/Gateways/KuveytPos.php
@@ -17,7 +17,6 @@
 use Mews\Pos\Entity\Card\CreditCardInterface;
 use Mews\Pos\Event\RequestDataPreparedEvent;
 use Mews\Pos\Exceptions\HashMismatchException;
-use Mews\Pos\Exceptions\NotImplementedException;
 use Mews\Pos\Exceptions\UnsupportedPaymentModelException;
 use Mews\Pos\Exceptions\UnsupportedTransactionTypeException;
 use Mews\Pos\PosInterface;
@@ -114,7 +113,15 @@ public function get3DFormData(array $order, string $paymentModel, string $txType
      */
     public function makeRegularPayment(array $order, CreditCardInterface $creditCard, string $txType): PosInterface
     {
-        throw new NotImplementedException();
+        throw new UnsupportedPaymentModelException();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function makeRegularPostPayment(array $order): PosInterface
+    {
+        throw new UnsupportedPaymentModelException();
     }
 
     /**

diff --git a/src/Gateways/PayFlexCPV4Pos.php b/src/Gateways/PayFlexCPV4Pos.php
@@ -128,12 +128,20 @@ public function make3DHostPayment(Request $request, array $order, string $txType
         return $this->make3DPayPayment($request, $order, $txType);
     }
 
+    /**
+     * @inheritDoc
+     */
+    public function status(array $order): PosInterface
+    {
+        throw new UnsupportedTransactionTypeException();
+    }
+
     /**
      * @inheritDoc
      */
     public function history(array $data): PosInterface
     {
-        throw new UnsupportedPaymentModelException();
+        throw new UnsupportedTransactionTypeException();
     }
 
     /**

diff --git a/src/Gateways/PayForPos.php b/src/Gateways/PayForPos.php
@@ -112,7 +112,9 @@ public function make3DPayPayment(Request $request, array $order, string $txType)
      */
     public function make3DHostPayment(Request $request, array $order, string $txType): PosInterface
     {
-        return $this->make3DPayPayment($request, $order, $txType);
+        $this->response = $this->responseDataMapper->map3DHostResponseData($request->request->all(), $txType, $order);
+
+        return $this;
     }
 
     /**

diff --git a/src/Gateways/ToslaPos.php b/src/Gateways/ToslaPos.php
@@ -114,7 +114,17 @@ public function make3DPayPayment(Request $request, array $order, string $txType)
      */
     public function make3DHostPayment(Request $request, array $order, string $txType): PosInterface
     {
-        return $this->make3DPayPayment($request, $order, $txType);
+        $request = $request->request;
+
+        if ($this->is3DAuthSuccess($request->all()) && !$this->requestDataMapper->getCrypt()->check3DHash($this->account, $request->all())) {
+            throw new HashMismatchException();
+        }
+
+        $this->response = $this->responseDataMapper->map3DHostResponseData($request->all(), $txType, $order);
+
+        $this->logger->debug('finished 3D payment', ['mapped_response' => $this->response]);
+
+        return $this;
     }
 
     /**

diff --git a/src/Serializer/PayFlexV4PosSerializer.php b/src/Serializer/PayFlexV4PosSerializer.php
@@ -12,7 +12,6 @@
 use Symfony\Component\Serializer\Encoder\XmlEncoder;
 use Symfony\Component\Serializer\Exception\NotEncodableValueException;
 use Symfony\Component\Serializer\Serializer;
-use function sprintf;
 use function strip_tags;
 
 class PayFlexV4PosSerializer implements SerializerInterface
@@ -46,7 +45,7 @@ public static function supports(string $gatewayClass): bool
     public function encode(array $data, string $txType): string
     {
         if (PosInterface::TX_TYPE_HISTORY === $txType || PosInterface::TX_TYPE_ORDER_HISTORY === $txType) {
-            throw new DomainException(sprintf('Serialization of the transaction %s is not supported', $txType));
+            throw new DomainException(\sprintf('Serialization of the transaction %s is not supported', $txType));
         }
 
         if (PosInterface::TX_TYPE_STATUS === $txType) {

diff --git a/tests/Unit/Crypt/PayFlexCP4CryptTest.php b/tests/Unit/Crypt/PayFlexCP4CryptTest.php
@@ -17,9 +17,6 @@
  */
 class PayFlexCP4CryptTest extends TestCase
 {
-    /** @var array<string, string>|array<string, float> */
-    public array $order = [];
-
     public PayFlexCPV4Crypt $crypt;
 
     private PayFlexAccount $account;

diff --git a/tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php
@@ -31,7 +31,7 @@ class GarantiPosRequestDataMapperTest extends TestCase
 
     private GarantiPosRequestDataMapper $requestDataMapper;
 
-    private $order;
+    private array $order;
 
     private $config;
 

diff --git a/tests/Unit/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapperTest.php b/tests/Unit/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapperTest.php
@@ -470,7 +470,7 @@ public static function paymentDataProvider(): iterable
     public static function threeDPaymentDataProvider(): array
     {
         return [
-            'authFail1'                 => [
+            '3d_auth_fail'                 => [
                 'order'              => [],
                 'txType'             => PosInterface::TX_TYPE_PAY_AUTH,
                 'threeDResponseData' => [
@@ -517,7 +517,7 @@ public static function threeDPaymentDataProvider(): array
                     'installment_count'    => 0,
                 ],
             ],
-            'auth_success_payment_fail' => [
+            '3d_auth_success_payment_fail' => [
                 'order'              => [],
                 'txType'             => PosInterface::TX_TYPE_PAY_PRE_AUTH,
                 'threeDResponseData' => [
@@ -584,7 +584,7 @@ public static function threeDPaymentDataProvider(): array
                     'installment_count'    => 0,
                 ],
             ],
-            'success1'                  => [
+            'success1'                     => [
                 'order'              => [],
                 'txType'             => PosInterface::TX_TYPE_PAY_PRE_AUTH,
                 'threeDResponseData' => [