Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): deployment after reloading config #917

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

luckasRanarison
Copy link
Contributor

  • Fixes typegraph deployment bug using meta dev after changing metatype.yml and added more watcher tests.

Migration notes


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@luckasRanarison luckasRanarison changed the title fix: deployment after reloading config fix(cli): deployment after reloading config Nov 14, 2024
@luckasRanarison luckasRanarison requested a review from a team November 14, 2024 06:30
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (7681e24) to head (072bed8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/utils/meta.ts 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   77.58%   77.59%   +0.01%     
==========================================
  Files         149      149              
  Lines       18385    18408      +23     
  Branches     1788     1789       +1     
==========================================
+ Hits        14264    14284      +20     
- Misses       4098     4101       +3     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luckasRanarison luckasRanarison merged commit 0273360 into main Nov 14, 2024
13 checks passed
@luckasRanarison luckasRanarison deleted the fix/reload-metatype-yaml branch November 14, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants