Vectory #554
Merged
Vectory #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeymorozov
force-pushed
the
vectory
branch
from
172616b to
2cbb276
Compare
|
@alexeymorozov The error in spec is simply an expectation that if Inkspace is not installed, SVGs cannot be converted to EMF, which is no longer applicable now that vectory exists; so you can simply remove that test from spec/isodoc/figures_spec.rb line 705. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 95.83% 96.14% +0.31%
==========================================
Files 78 78
Lines 5403 5372 -31
==========================================
- Hits 5178 5165 -13
+ Misses 225 207 -18 ☔ View full report in Codecov by Sentry. |
alexeymorozov
force-pushed
the
vectory
branch
2 times, most recently
from
7b23e67 to
4378cf0
Compare
alexeymorozov
force-pushed
the
vectory
branch
from
38016a8 to
ee1ba8a
Compare
opoudjis
approved these changes
Dec 28, 2023
|
@opoudjis please merge after approval. I’ll merge this this time. Thanks. |
|
Wanted to give you the chance to comment. |
|
Thanks, I’ll definitely comment if I have to even after merging :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553
Metanorma PR checklist