-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some shortenings, some credits and ALT restorations. Some edits #4559
Conversation
…horten sucexeloni. Add closed form onuniorsuc.
…allow(s)'. Typos.
Ugh, sorry, I keep making revision messages and OLD theorems on autopilot. I'll try to go through my recent changes and see what else I've missed. |
Don't be sorry please ! I really like these ax-pow and ax-un removals you've made. I'm going over the PRs mentioned above by @wlammen and there is very little to (maybe) update. I'm making a shortlist right now and will submit it here to your ("plural your", as in "you all") judgment. |
I went over the PRs mentioned by Wolf. In my latest (and tentatively last) commit in this PR, I restored two "OLD" proofs as "ALT" since they are much shorter. These are the only two cases I found (other OLD proofs are only slightly shorter or are longer). I also found one shortening, which is minor, so didn't keep an OLD version. I think that's all (so that the "shortlist" of bordercases I mentioned above is actually very short, since it is empty !). |
I'll agree that the Contributed lines are far from an exact science. The language we put at https://us.metamath.org/mpeuni/conventions-comments.html is "An exception should be made if a theorem is essentially an extract or a variant of an already existing theorem, in which case the contributor should be that of the statement from which it is derived" Or to say in another way which I think means largely the same thing, preserve the oldest contributed line which seems plausible. We don't actually have a guideline saying that the |
Review by commit. Commit messages are self-descriptive.