Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intuitionize Ring and CRing up until iscrngd #4540

Merged
merged 31 commits into from
Jan 8, 2025
Merged

Conversation

jkingdon
Copy link
Contributor

@jkingdon jkingdon commented Jan 6, 2025

This is the first part of the rather long section "Definition and basic properties of unital rings".

Most of the intuitionizing is pretty straightforward #4495 style set existence changes.

The one change to set.mm was inspired by #4522 (comment)

@avekens
Copy link
Contributor

avekens commented Jan 7, 2025

The one change to set.mm was inspired by #4522 (comment)

~ringi was deleted - why not making it a lemma ~ringdilem like ~srgdilem in #4522?

@jkingdon
Copy link
Contributor Author

jkingdon commented Jan 7, 2025

The one change to set.mm was inspired by #4522 (comment)

~ringi was deleted - why not making it a lemma ~ringdilem like ~srgdilem in #4522?

What I said in the commit message was:

This was only used to prove ringdi and ringdir . Furthermore, the proof
of ringi to some extent consisted of separate proofs for ringdi and ringdir
which were then joined via jca at the end. The new proofs for ringdi
and ringdir are based on the former ringi proof.

But I guess it doesn't really matter much to me one way or the other 🤷 . I'll bring back ringi (renaming to ringdilem) unless someone wants to advocate for getting rid of it.

This is the syntax , df-ring , and df-cring .  Copied without change
from set.mm.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
This is ringdilem , ringdi , and ringdir .  Copied without change from
set.mm.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Includes lemma ringidmlem , which is stated as in set.mm.  Its proof
needs some intuitionizing but is basically the set.mm proof.

ringlidm and ringridm are copied without change from set.mm.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Copied from set.mm, with the only change being to the comment, to remove
a reference to a theorem iset.mm doesn't have yet.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs a small amount of intuitionizing
but is basically the set.mm proof.
Stated as in set.mm.  The proof needs a little bit of intuitionizing but
is basically the set.mm proof.
@jkingdon
Copy link
Contributor Author

jkingdon commented Jan 8, 2025

I have added the change to keep ringi but rename to ringdilem

@avekens
Copy link
Contributor

avekens commented Jan 8, 2025

~ringi was deleted - why not making it a lemma ~ringdilem like ~srgdilem in #4522?

What I said in the commit message was:

This was only used to prove ringdi and ringdir . Furthermore, the proof
of ringi to some extent consisted of separate proofs for ringdi and ringdir
which were then joined via jca at the end. The new proofs for ringdi
and ringdir are based on the former ringi proof.

The proof does not consist of two separate parts which are joined at the end via ~jca (step 22): the common part starts at step 16! Therefore, I think the existence of ~ringdilem ist justified.

@jkingdon
Copy link
Contributor Author

jkingdon commented Jan 8, 2025

The proof does not consist of two separate parts which are joined at the end via ~jca (step 22): the common part starts at step 16! Therefore, I think the existence of ~ringdilem ist justified.

Yeah, after I wrote that I took a closer look and I'd agree that the common part is a bit bigger than I had thought. Whether 16 steps is big or small in the grand scheme of things is why this is a bit of a 🤷 for me, but we've already decided to keep the lemma, so we'll do that.

@jkingdon jkingdon merged commit ccab867 into metamath:develop Jan 8, 2025
10 checks passed
@jkingdon jkingdon deleted the crg branch January 8, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants