Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename syl5bi to biimtrid (part 4) #4532

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Rename syl5bi to biimtrid (part 4) #4532

merged 1 commit into from
Jan 5, 2025

Conversation

jkingdon
Copy link
Contributor

@jkingdon jkingdon commented Jan 4, 2025

As described in #4504

avekens
avekens requested changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the change in changes-set.txt

avekens
avekens approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see - the process of replacements is not finished yet. So changes-set.txt should be updated after the replacements are finished, and ~syl5bi was removed.

@jkingdon
Copy link
Contributor Author

jkingdon commented Jan 5, 2025

Oh, I see - the process of replacements is not finished yet. So changes-set.txt should be updated after the replacements are finished, and ~syl5bi was removed.

Yeah, the first pull request of the series changed the relevant line to:

underway  syl5bi    biimtrid

and the plan is to move the entry to DONE with the last pull request of the series.

@jkingdon jkingdon merged commit d6c9df3 into metamath:develop Jan 5, 2025
10 checks passed
@jkingdon jkingdon deleted the biimtrid-4 branch January 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlammen wlammen wlammen approved these changes

@avekens avekens avekens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkingdon @avekens @wlammen