Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exel (from mathbox sn-el), exex, exneq (from proof of dtru) #4521

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

benjub
Copy link
Contributor

@benjub benjub commented Jan 2, 2025

Add exel (from mathbox sn-el), exex, exneq (from proof of dtru), and update dtru and comments.

FYI @icecream17 @GinoGiotto @BTernaryTau and Rohan Ridenour, who contributed to the current form of these results.

@benjub
Copy link
Contributor Author

benjub commented Jan 2, 2025

Copy link
Contributor

@icecream17 icecream17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could link to elALT2 in sn-exelALT (sn-exelALT is to elALT2 what exel is to el), or I could do that in a future pr

9-Oct-2024.) (Proof modification is discouraged.)
(New usage is discouraged.) $)
(Contributed by NM, 7-Nov-2006.) Avoid ~ ax-13 . (Revised by BJ,
31-May-2019.) (Revised by Gino Giotto, 5-Sep-2023.) Avoid ~ ax-12 .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember somewhere that you removed ax-13 before me, so you can remove my credit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you had also removed ax-13 later and independently (since bj-dtru was in my mathbox, it was less visible). Following your comment, I am removing the tag concerning your revision.

~ ax-12 . (Revised by Rohan Ridenour, 9-Oct-2024.) Use ~ ax-pr instead
of ~ ax-pow . (Revised by BTernaryTau, 3-Dec-2024.) Extract this
result from the proof from ~ dtru . (Revised by BJ, 2-Jan-2025.) $)
exex $p |- E. x E. y -. x = y $=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer exexneq here instead of exex. I would like exex to be bj-exexbiex when it will be moved in main. Notice that I called exexw with this idea in mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had considered that label exexneq before the PR, but thought it might be too long. Since you also thought of it and @icecream17 agrees, I'll go with it: better to be more explicit, even if slightly longer.

(On the other hand, exexw may not be explicit enough, compared to exexbiexw, even though the latter is quite long. And for instance, alex already exists for something different from bj-alexbiex. But that's another story.)

@benjub
Copy link
Contributor Author

benjub commented Jan 3, 2025

could link to elALT2 in sn-exelALT (sn-exelALT is to elALT2 what exel is to el), or I could do that in a future pr

Done. You may of course update its comment later, since it is in your mathbox. Note the difference of nature between el (or elALT*) on the one hand and exel (or sn-exelALT) on the other hand: free variables are implicitly universally quantified.

@benjub
Copy link
Contributor Author

benjub commented Jan 3, 2025

set.mm Outdated
Comment on lines 51091 to 51092
$( $j usage 'exel' avoids 'ax-5' 'ax-7' 'ax-8' 'ax-9' 'ax-10 'ax-11'
'ax-12' 'ax-13''ax-ext' 'ax-sep' 'ax-nul' 'ax-pow'; $)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metamath knife panics because of the missing space between ax-13 and ax-ext.
A closing quote is also missing after ax-10 (here and in below), but that does not seem to be an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly Metamath knife should not panic though, but raise an error. I'll open an issue to track this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written issue #174 of metamath-knife to track this issue, you can follow-up fixes there @benjub.

PS. Sorry I've only had time this weekend to check this in more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be sorry ! Thanks for fixing this PR and for opening the associated issue.

@benjub benjub merged commit e12e027 into metamath:develop Jan 5, 2025
10 checks passed
@benjub benjub deleted the dtru branch January 5, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants