Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize ax-13 usage 27 #3873

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Minimize ax-13 usage 27 #3873

merged 1 commit into from
Mar 17, 2024

Conversation

GinoGiotto
Copy link
Contributor

Part of groups.google.com/g/metamath/c/OB2_9sYgDfA.

Continuation of #3796.

This PR drops ax-13 from 167 theorems. Full axiom usage here: 8ea714f

Affected mathboxes:
@tirix mathbox (just the leftover reuxfrdf).
@glacode mathbox.

Copy link
Contributor

@wlammen wlammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In limsuppnfd (in a mathbox) I noticed that the proof became shorter. The reason was that two instances of cbvralv were substituted with one of cbvral2vw. I consider this as acceptable. But it is easier for me to review such massive changes when there is a direct mapping between old and new versions of theorems in proofs. A separate minimizing sweep could then improve on proof structure.

@GinoGiotto
Copy link
Contributor Author

Because of the way the script is designed, these "special shorter proofs" can happen, although they should be so rare to not constitute a problem (and they are further improvements, so I didn't consider them an issue). Trying to avoid these cases on purpose is a bit difficult. Best thing I can do at the moment is to look for them manually and report them in the PR description.

@wlammen wlammen merged commit 627540a into metamath:develop Mar 17, 2024
10 checks passed
@GinoGiotto GinoGiotto deleted the 27 branch March 21, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants