Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm ax-10 from a couple of sbied* variants #3802

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

wlammen
Copy link
Contributor

@wlammen wlammen commented Jan 28, 2024

This particular example shows that some recently added theorems miss some scrutiny, and maybe need to be reworked.

  1. sbiedw need not depend on ax-10. Removing it has a cascading effect on other theorems that uses it.
  2. In the sbied environment references to freshly added variants are missing all over the place.

I did not particularly look for a theorem failing in these respects. sbiedw was a random hit. Actually I wanted to visit sbiev, and it happend to be next to it.

set.mm Outdated Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
Copy link
Contributor

@benjub benjub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but I'd still like you apply my suggestions.

set.mm Outdated Show resolved Hide resolved
@wlammen wlammen merged commit b6dd646 into metamath:develop Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants