Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc #3793

Merged
merged 5 commits into from
Jan 27, 2024
Merged

Misc #3793

merged 5 commits into from
Jan 27, 2024

Conversation

GinoGiotto
Copy link
Contributor

  • Added $j tags to relevant recently edited theorems12 to ensure they remain ax-13 free.

  • Apply consistency in label naming: in my first PR about adding DV1 the original theorems were renamed as *ALT, while in the second one2 they were renamed as *g. In this PR, I've renamed the *ALT versions of the first PR1 to *g for uniformity (and adapted their comments).

  • Updated changes-set.txt to document the renaming of original versions of the first PR1 to *g. Given the brief existence of the *ALT versions, I believe we can consider the original theorems directly converted to *g, without explicitly mentioning their temporary existence as *ALT.

  • Added proposed label renamings in changes-set.txt that better match established conventions. While I don't plan to implement these renamings anytime soon, this inclusion ensures they won't be forgotten. As wlammen said, in the end you can have both: reduced axiom usage and a label naming that suits the current practice. I welcome anyone willing to take up the renaming task.

Footnotes

  1. First PR about adding DV conditions: https://github.com/metamath/set.mm/pull/3778 2 3 4

  2. Second PR about adding DV conditions: https://github.com/metamath/set.mm/pull/3781 2

set.mm Show resolved Hide resolved
Copy link
Contributor

@benjub benjub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @wlammen's remark, and provided you address it, I approve.

@GinoGiotto
Copy link
Contributor Author

Sorry for the corrections, it should be good now.

@benjub benjub merged commit 4b19698 into metamath:develop Jan 27, 2024
10 checks passed
@GinoGiotto GinoGiotto deleted the misc branch March 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants