Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove same-alphabet requirement from ccatval1 #3788

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

jamesjer
Copy link
Contributor

Other changes:

  • ccats1val1: remove antecedent of sethood of S
  • ccat2s1p1: remove antecedent of sethood of Y
  • ccat2s1p2: remove antecedent of sethood of X
  • ccatval1: add $d x A $. for the new variable

As before, I have looked for opportunities to shrink each proof a little, to counteract the small size growth due to introducing a new variable. I have done many of these proofs already in previous rounds of removing same-alphabet requirements, so there are quite a few instances of single-digit growth.

                   Change in size
Theorem             Bytes   Steps
-----------------  ------  ------
ccatval1               -4      -5
ccatsymb               +1      +1
ccatfv0                +1      +1
ccatval1lsw            +1      +1
ccatrid                +1      +1
ccatass                +4      +5
ccatrn                +14    -655
ccats1val1             +1      -3
ccat1st1st           -104     -84
ccat2s1p1             -75     -81
ccat2s1p2             -74    -100
lswccats1fst           +1      +1
ccatw2s1p1            -23     -96
ccat2s1fvw            -17    -105
ccatswrd               +1      +1
ccatpfx                +1      +1
pfxccat1               +1      +1
cats1un               -53     -73
swrdccatin1          -151    -819
pfxccatin12lem3       -42    -128
pfxccatin12           -16     -75
splfv1                 -5      -2
splfv2a                +1      +1
revccat                +2      +2
cshwidxmod           -195    -997
cats1fv                +1      +1
ccat2s1fvwALT          +1      +1
gsumsgrpccat           +1      +1
gsumccatOLD            +1      +1
gsmsymgrfixlem1       -18    -285
gsmsymgreqlem2       -117    -508
efgsp1                 +4      +4
efgredlemd             +4      +2
efgrelexlemb           +1      +1
tgcgr4               -168    -384
wwlksnext             -31     -83
clwwlkccatlem          +4     +25
clwwlkel               +2     +58
clwwlkwwlksb           -6    -170
wwlksext2clwwlk      -156    -695
clwwlknonwwlknonb      -5    -775
ccatf1                -83   -3483
cycpmco2lem2           +8      -8
cycpmco2lem4           -1     -51
cycpmco2lem5           +4     -36
cycpmco2              -10    -274
signstfvn              +2      +1
signstfvp              -9    -140
signstfvneq0         -102   -1683
lpadleft               +1      +1
-----------------  ------  ------
Total               -1401  -11686

* ccats1val1: remove antecedent of sethood of S
* ccat2s1p1: remove antecedent of sethood of Y
* ccat2s1p2: remove antecedent of sethood of X
Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

17-Jan-24 mteqand [same] moved from SN's mathbox to main set.mm
15-Jan-24 sseqtr4d sseqtrrd
14-Jan-24 sseqtr4i sseqtrri
14-Jan-24 ccat2s1len [same] revised - eliminated unnecessary antecedents
14-Jan-24 wlklenvclwlk [same] revised - eliminated unnecessary antecedent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is not to add revised theorems to the changes-set, but to append an OLD to the former version and to add "(Proof modification is discouraged.)" and "(New usage is discouraged.)" to it. Furthermore, the comment should contain a hint that this version is obsolete.

See, for example, ~pm2.18OLD:

  $( Obsolete version of ~ pm2.18 as of 17-Nov-2023.  (Contributed by NM,
     29-Dec-1992.)  (Proof modification is discouraged.)
     (New usage is discouraged.) $)
  pm2.18OLD $p |- ( ( -. ph -> ph ) -> ph ) $=

TThese OLD theorems will be deleted after about a year.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ccat2s1len and ~wlklenvclwlk were revised in a previous PR? Then the corresponding OLD theorems should be added belatedly.

Copy link
Contributor

@avekens avekens Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is not to add revised theorems to the changes-set, ....

OK, there are no exact conventions when and how to add entries to changes-set.txt. I had a look at older entries, and actually there are many about revisions. Therefore, I do not insist in removing this entries anymore.

set.mm Outdated Show resolved Hide resolved
set.mm Outdated
@@ -150291,11 +150293,12 @@ computer programs (as last() or lastChar()), the terminology used for
UPRABUCUMUDUMUEUFUG $.

$( Value of a symbol in the left half of a word concatenated with a single
symbol. (Contributed by Alexander van der Vekens, 5-Aug-2018.) $)
ccats1val1 $p |- ( ( W e. Word V /\ S e. V /\ I e. ( 0 ..^ ( # ` W ) ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained above, this versin should be kept as ccats1val1OLD.

set.mm Outdated

$( Extract the first of two concatenated singleton words. (Contributed by
Alexander van der Vekens, 22-Sep-2018.) $)
ccat2s1p1 $p |- ( ( X e. V /\ Y e. V )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

set.mm Outdated

$( Extract the second of two concatenated singleton words. (Contributed by
Alexander van der Vekens, 22-Sep-2018.) $)
ccat2s1p2 $p |- ( ( X e. V /\ Y e. V )
-> ( ( <" X "> ++ <" Y "> ) ` 1 ) = Y ) $=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

set.mm Outdated
@@ -150424,15 +150421,15 @@ computer programs (as last() or lastChar()), the terminology used for
ccat2s1fvw $p |- ( ( ( W e. Word V /\ I e. NN0 /\ I < ( # ` W ) )
/\ ( X e. V /\ Y e. V ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ( X e. V /\ Y e. V ) is also unnecessary here.

set.mm Outdated
@@ -150391,21 +150388,21 @@ computer programs (as last() or lastChar()), the terminology used for
wrdsymb1 syldan cfzo simpl s1cld cn cn0 lencl elnnnn0c biimpri sylan lbfzo0
sylibr ccatval1 syl3anc eqtr4d ) ABCZDZEAFGZHIZJZAKAGZLZMNZOGZUSKVAGZUOUQUS
BDVBUSPBARZUSBAQSURUOUTUNDKKUPTNDZVCUSPUOUQUAURUSBVDUBURUPUCDZVEUOUPUDDZUQV
FBAUEVFVGUQJUPUFUGUHUPUIUJBAUTKUKULUM $.
FBAUEVFVGUQJUPUFUGUHUPUIUJBBAUTKUKULUM $.

$( Extract the symbol of the first singleton word of a word concatenated with
this singleton word and another singleton word. (Contributed by Alexander
van der Vekens, 22-Sep-2018.) (Proof shortened by AV, 1-May-2020.) $)
ccatw2s1p1 $p |- ( ( ( W e. Word V /\ ( # ` W ) = N )
/\ ( X e. V /\ Y e. V ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Y e. V is also unnecessary here.

@avekens
Copy link
Contributor

avekens commented Jan 28, 2024

To not block this PR any longer, I will solve the merge conflicts and approve this PR, so that it can be merged. I will incorporate my review remarks in a separate PR afterwards. @benjub do you agree?

Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged (see my previous comment).

17-Jan-24 mteqand [same] moved from SN's mathbox to main set.mm
15-Jan-24 sseqtr4d sseqtrrd
14-Jan-24 sseqtr4i sseqtrri
14-Jan-24 ccat2s1len [same] revised - eliminated unnecessary antecedents
14-Jan-24 wlklenvclwlk [same] revised - eliminated unnecessary antecedent
Copy link
Contributor

@avekens avekens Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is not to add revised theorems to the changes-set, ....

OK, there are no exact conventions when and how to add entries to changes-set.txt. I had a look at older entries, and actually there are many about revisions. Therefore, I do not insist in removing this entries anymore.

@benjub
Copy link
Contributor

benjub commented Jan 28, 2024

To not block this PR any longer, I will solve the merge conflicts and approve this PR, so that it can be merged. I will incorporate my review remarks in a separate PR afterwards. @benjub do you agree?

Agreed. And then, the antecedents you noticed are unnecessary can be removed in a later PR.

@avekens avekens merged commit 6f0b966 into metamath:develop Jan 28, 2024
10 checks passed
@avekens
Copy link
Contributor

avekens commented Jan 29, 2024

While working on the removal of the unnecessary antecedents, I detected more such cases (and maybe there will be even more...). I try to revise all this cases with my announced PR (may take a little bit longer as expected now).

avekens added a commit to avekens/set.mm that referenced this pull request Jan 29, 2024
Follow up of PR metamath#3788:
* reconstructed OLD theorems: catlenOLD, ccatval1OLD, ccat2s1lenOLD, ccats1val1OLD, ccat2s1p1OLD, ccat2s1p2OLD, wlklenvclwlkOLD,
* some unnecessary antecedents removed: ccatw2s1ass, ccatw2s1p1, ccat2s1fvw, ccat2s1fst, ccatw2s1ccatws2, ccat2s1fvwALT
avekens added a commit that referenced this pull request Feb 2, 2024
Follow up of PR #3788:
* reconstructed OLD theorems: catlenOLD, ccatval1OLD, ccat2s1lenOLD, ccats1val1OLD, ccat2s1p1OLD, ccat2s1p2OLD, wlklenvclwlkOLD,
* some unnecessary antecedents removed: ccatw2s1ass, ccatw2s1p1, ccat2s1fvw, ccat2s1fst, ccatw2s1ccatws2, ccat2s1fvwALT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants