Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximal Ideals #3787

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Maximal Ideals #3787

merged 4 commits into from
Apr 11, 2024

Conversation

tirix
Copy link
Contributor

@tirix tirix commented Jan 22, 2024

Definition and theorems about maximal ideals ported from Jeff Madsen's mathbox.
I also added a chapter about the sumset of two sets, which is useful for dealing with operations on ideals.

Copy link
Contributor

@savask savask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I'm especially happy to see some theorems on sumsets. I think the theory of sumsets is very worth formalizing in set.mm (after agreeing on definitions, see my comment on LSSum). It would be great to see some results from additive combinatorics formalized, like Ruzsa's triangle inequality.

set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Outdated Show resolved Hide resolved
set.mm Show resolved Hide resolved
@tirix tirix marked this pull request as draft January 23, 2024 10:41
@tirix
Copy link
Contributor Author

tirix commented Jan 23, 2024

I'm converting this PR to draft until it is reworked using LSSum, then I will ask for a review again.
In the mean time it's Ok if other PR like e.g. #3789 are merged, I can adapt (this happened before).

set.mm Outdated Show resolved Hide resolved
set.mm Outdated Show resolved Hide resolved
@tirix tirix marked this pull request as ready for review April 9, 2024 12:11
@tirix tirix requested review from savask and benjub April 10, 2024 07:56
Copy link
Contributor

@savask savask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, as always! The definition of a spectrum makes me wonder if you have an eye on algebraic geometry.

I think it's also worth mentioning that some earlier theorems in your pull request, like lsmidllsp, work for Rng-s (non-unital rings). The benefit here is that ideals in an Rng are Rng-s themselves, and that simplifies arguments in some cases.

@tirix tirix mentioned this pull request Apr 10, 2024
@tirix
Copy link
Contributor Author

tirix commented Apr 10, 2024

Nice changes, as always! The definition of a spectrum makes me wonder if you have an eye on algebraic geometry.

Thanks! Yes, I had been looking a some algebraic geometry at the time I originally wrote this PR (in January), and I thought that the spectrum of a ring was a relatively low-hanging fruit to pick.

I think it's also worth mentioning that some earlier theorems in your pull request, like lsmidllsp, work for Rng-s (non-unital rings). The benefit here is that ideals in an Rng are Rng-s themselves, and that simplifies arguments in some cases.

Indeed. Since this PR has been pending for a long time, maybe it's better to just merge as-is, and refine later?

@tirix tirix merged commit 0d31f3a into metamath:develop Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants