-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximal Ideals #3787
Maximal Ideals #3787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'm especially happy to see some theorems on sumsets. I think the theory of sumsets is very worth formalizing in set.mm (after agreeing on definitions, see my comment on LSSum
). It would be great to see some results from additive combinatorics formalized, like Ruzsa's triangle inequality.
I'm converting this PR to draft until it is reworked using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, as always! The definition of a spectrum makes me wonder if you have an eye on algebraic geometry.
I think it's also worth mentioning that some earlier theorems in your pull request, like lsmidllsp
, work for Rng
-s (non-unital rings). The benefit here is that ideals in an Rng
are Rng
-s themselves, and that simplifies arguments in some cases.
Thanks! Yes, I had been looking a some algebraic geometry at the time I originally wrote this PR (in January), and I thought that the spectrum of a ring was a relatively low-hanging fruit to pick.
Indeed. Since this PR has been pending for a long time, maybe it's better to just merge as-is, and refine later? |
Definition and theorems about maximal ideals ported from Jeff Madsen's mathbox.
I also added a chapter about the sumset of two sets, which is useful for dealing with operations on ideals.