Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sbralie #3574

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fixed sbralie #3574

merged 1 commit into from
Oct 20, 2023

Conversation

GinoGiotto
Copy link
Contributor

Requested by @benjub in #3571 (comment)

Copy link
Contributor

@benjub benjub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this MR restore the original proofs ? I don't understand: in #3571 (comment) @avekens noticed that the proof became longer, and now it seems that it becomes even longer instead of going back to the original ?

@GinoGiotto
Copy link
Contributor Author

GinoGiotto commented Oct 16, 2023

Does this MR restore the original proofs ? I don't understand: in #3571 (comment) @avekens noticed that the proof became longer, and now it seems that it becomes even longer instead of going back to the original ?

Ah, maybe I misinterpreted your request. What I did here is coupling DV(x,ps) and DV(y,ph) as you mentioned, but I still kept the new [ y / x ] notation. Restoring the original statement and proof would mean to go back to the [ x / y ] notation, which is against the request of issue #777 (sbralie is in the list of #777).

Also avekens accepted the new proof after I explained the reason of why it is longer: #3571 (comment) #3571 (comment)

EDIT: if you mean to restore the original proof only, I'm not sure that is possible because of the fact that I kept x = y in the hypothesis, so as you mentioned in #3571 this is a little more than a simple variable renaming.

EDIT2: same thing for ph and ps. I kept ph <-> ps in the hypothesis instead of switching into ps <-> ph and this caused an additional proof longening.

set.mm Show resolved Hide resolved
Copy link
Contributor

@tirix tirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me as-is.

@wlammen wlammen merged commit e35f19a into metamath:develop Oct 20, 2023
10 checks passed
@GinoGiotto GinoGiotto deleted the ph-ps branch October 25, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants