Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together #1459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚠️ Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together #1459

wants to merge 1 commit into from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Sep 23, 2024 •
edited
Loading

When making IPAm into a provider for CAPI, I needed to change the namespace where IPAM is living and how IPAM is deployed. This PR is made to match those changes in IPAM. There are also changes to CAPM3 These are the related PRs:

These new changes are dependent from each other so the test are not passing in the PRs. This PR changes the way IPAM is deployed with CAMP3 and tests the 2 dependent PR branches together.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

1 similar comment
@mquhuy
Copy link
Member

mquhuy commented Sep 23, 2024

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 54c69b2 to f522417 Compare September 30, 2024 10:56
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from f522417 to 809df47 Compare September 30, 2024 11:48
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 809df47 to 9ef6cc2 Compare September 30, 2024 12:15
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 9ef6cc2 to b269826 Compare October 1, 2024 09:40
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 2 times, most recently from 37b23a2 to 4742bea Compare October 2, 2024 06:25
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 4742bea to 85efbfa Compare October 2, 2024 07:59
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

1 similar comment
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 85efbfa to e5e954c Compare October 9, 2024 07:26
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from e5e954c to 85a3585 Compare October 9, 2024 08:49
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

2 similar comments
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta changed the title Test IPAM and CAPM3 changes together WIP: Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together Oct 16, 2024
@metal3-io-bot
Copy link
Collaborator

@peppi-lotta: The following commands are available to trigger required jobs:

  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-release-1-8
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-bml-integration-test-centos
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-basic-test-release-1-8
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-feature-test-release-1-6-features
  • /test metal3-centos-e2e-feature-test-release-1-6-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-6-remediation
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-centos-e2e-feature-test-release-1-8-features
  • /test metal3-centos-e2e-feature-test-release-1-8-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-8-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-centos-release-1-6
  • /test metal3-dev-env-integration-test-centos-release-1-7
  • /test metal3-dev-env-integration-test-centos-release-1-8
  • /test metal3-dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-dev-env-integration-test-ubuntu-release-1-7
  • /test metal3-dev-env-integration-test-ubuntu-release-1-8
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-7
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-8
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-8
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-8
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-remediation
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • shellcheck

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 31fb996 to 1f16610 Compare November 1, 2024 11:54
@peppi-lotta
Copy link
Member Author

/test /test metal3-centos-e2e-integration-test-main
/test metal3-dev-env-integration-test-ubuntu-main

This was referenced Nov 7, 2024
Open
Open
@peppi-lotta peppi-lotta changed the title WIP: Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together ⚠️ Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together Nov 8, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 1f16610 to 15b5024 Compare November 8, 2024 07:22
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-centos-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 15b5024 to 32d8ed7 Compare December 2, 2024 12:34
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 2, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 2 times, most recently from 6461fa8 to a4cec6b Compare December 5, 2024 12:05
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from a4cec6b to 555dbe9 Compare December 5, 2024 12:08
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 555dbe9 to 4944d81 Compare January 2, 2025 10:43
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2025
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Jan 2, 2025 •
edited
Loading

@peppi-lotta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main e120680 link false /test metal3-ubuntu-e2e-integration-test-main
metal3-centos-e2e-integration-test-release-1-8 31fb996 link true /test metal3-centos-e2e-integration-test-release-1-8
metal3-centos-e2e-integration-test-main 1f16610 link false /test metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@peppi-lotta
Test IPAM and CAPM3 changes together because tests don't pass alone d…
c8fe8e7 
…ue to namespace name change

Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 4944d81 to c8fe8e7 Compare January 3, 2025 07:15
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

kashifest
kashifest reviewed Jan 7, 2025
View reviewed changes
03_launch_mgmt_cluster.sh
@@ -485,7 +466,7 @@ update_component_image()
make set-manifest-image
;;
"IPAM")
make set-manifest-image-ipam
make set-manifest-image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are we making sure that this make target is now called within the IPAM repository not CAPM3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check function patch_IPAM() on line 521. Function update_component_image() is called from there after moving toip-address-managerdirectory. Also the last line of function patch_IPAM() returns the process back to the directory where the function was called from.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense, great
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peppi-lotta @mquhuy @metal3-io-bot @kashifest