Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PoC Hostnetworkless Ironic with VirtualMedia Using NodePorts #1433

Closed

Conversation

mboukhalfa
Copy link
Member

@mboukhalfa mboukhalfa commented Jun 19, 2024

⚠️ Do not merge this is only to demonstrate a PoC

This is a small PoC part of the short focus discussion metal3-io/baremetal-operator#1739. It demonstrate running Ironic without hostNetwork, limited to the virtualMedia use case, using a nodePort service.

Changes Needed

  1. Edit Ironic Deployment:

    • Remove hostNetwork: true.
    • Remove dnsmasq container.
    • Remove security restrictions to allow root access for debugging inside the containers.
  2. Add NodePort Service:

    • Map the following ports:
      - ironic
        30085:6385
      - inspector
        30050:5050
      - httpd
        30080:30080
      
    • Changed the httpd internal port because the HTTP_PORT variable from the dev-env is used in both internal and external configurations, which would require more changes to configure only the external port.
  3. Edit Ironic ConfigMap:

    • Remove PROVISIONING_IP so that the runironic script uses the pod's IP from the eth0 interface.
    • Add external Ironic IPs to be published to external components like IPA.
  4. Provisioning Networks:

  • Remove keepalived since it cannot access the ironicendpoint bridge and instead use manual commands to configure the bridge with the Ironic external IP.
  • Manually remove the IP from minikube and add it to the CP node when pivoting.

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 19, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboukhalfa. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-dev-env-integration-test-centos-main

@mboukhalfa mboukhalfa force-pushed the test-svc-nodePort/mboukhalfa branch 2 times, most recently from 59ef0fd to 26da13b Compare June 19, 2024 13:10
@mboukhalfa
Copy link
Member Author

/metal3-dev-env-integration-test-ubuntu-main

@mboukhalfa
Copy link
Member Author

/test metal3-dev-env-integration-test-centos-main

Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa mboukhalfa force-pushed the test-svc-nodePort/mboukhalfa branch from 26da13b to c2e2a8b Compare June 20, 2024 13:29
@mboukhalfa
Copy link
Member Author

/test metal3-dev-env-integration-test-centos-main

@zaneb
Copy link
Member

zaneb commented Jul 4, 2024

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2024
@metal3-io-bot
Copy link
Collaborator

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Collaborator

@metal3-io-bot: Closed this PR.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants