Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify mobile UI in wimp #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uday-kalyan-s
Copy link

problem

the search bar is too small in mobile layout which causes an overflowing of text (including the placeholder).

solution

the solution for this is well... simply increase the size. 80% seemed to work well and aligned with FIND MY in Samsung S20 layouts.

changes:

  • added media query for mobile which modifies .search-bar-container

modified layout

image

@uday-kalyan-s uday-kalyan-s changed the title increased size of search bar in mobile layout modify mobile UI in wimp Oct 14, 2024
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. But in the long term, we will have to do a lot of changes. It would be better to size everything (title, search bar, results) relative to a global container element and then change the container width (%) on different screens. Would you like to work on this? And if yes, should I merge this first or do you want to add to it?

Thanks for your contribution! 🚀

@uday-kalyan-s
Copy link
Author

ooh I see. the container element does sound like a good idea yeah. I'd love to fix the rest of Firefox issue in this PR itself we can merge it then. is it fine if I do it slowly over the week? I have a few lab tests/soc work coming up

@harshkhandeparkar
Copy link
Member

ooh I see. the container element does sound like a good idea yeah. I'd love to fix the rest of Firefox issue in this PR itself we can merge it then. is it fine if I do it slowly over the week? I have a few lab tests/soc work coming up

Sure, no problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants