[BUG-FIX] Make it so parsoid can contact nginx #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This bug was introduced in #49. Parsoid needs to contact nginx, but the networks were not set up correctly, which caused the visual editor to stop working.
Cause
I tested the new setup locally but I was only testing the source edit function. Developers should remember to use both Source Edit and Visual Editor when making changes to the wiki because VE is a popular choice among many users (especially people who are new to the wiki / mediawiki markup language)
Detection
After deploying the mediawiki update to 1.33, we realized that source edits were working but the Visual Editor was not working. The logs of the parsoid container had the reason for this error:
Action Items
Mitigation