Add new functions add_array and add_hash #374 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The are a copy of the current implementation of set_array and set_hash. This is a preparation for #309
As a preliminary work for #309 since set_array will change its behaviour but add_array will keep the functionality.
As a preliminary work for #309 since set_array will change its behaviour but add_array will keep the functionality.
TobiasNx
changed the title
blackwinter
requested changes
Oct 17, 2024
There was a problem hiding this comment.
I would suggest to change all set_* implementations to delegate to the corresponding add_* functions, so we don't have to maintain two identical implementations for each pair until the former have been replaced.
I would also argue that we should keep set_* where appropriate, because these are the "standard" functions; the new functions aren't supported by Catmandu (yet).
Similarly, all the tests should be left untouched in order to surface any actual behaviour changes once the set_* implementations are changed. Just add new ones where appropriate.
fsteeg
reviewed
Oct 18, 2024
|
@blackwinter like this? |
blackwinter
requested changes
Nov 6, 2024
blackwinter
approved these changes
Nov 7, 2024
fsteeg
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #374
This is a preparation for #309 which will change the behavior of all
set-functions asset_arrayandset_hashwhich will not create the intermediate structure of a path.Since we rely in context of oersi and lobid on this specific functionality I introduced
add_arrayandadd_hashwhich copy the current implementation ofset_arrayandset_hash.I also changed the tests from set_array and set_hash to add_array and add_hash since #307 will need new integration tests and java tests.