Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

495-testDrarft #570

Open
wants to merge 1 commit into
base: 495-objectSleep
Choose a base branch
from
Open

495-testDrarft #570

wants to merge 1 commit into from

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Nov 15, 2024

@fsteeg could you help me with the test? the objectSleeper?

@fsteeg
Copy link
Member

fsteeg commented Nov 19, 2024

You should first fix the compiler and build errors (missing imports, wrong file / class name, missing variables, formatting).

Conceptually, the idea looks good, though you will have to call process at some point to actually run the workflow, and instead of the if-statement, you should use something like assertTrue(timeElapsed >= sleepTime) to verify the result. But to compare them like this, they have to be numbers (instead of Instant), e.g. from System.nanoTime().

As expressed by my approval in #495, I think it would be fine to go without a test here, if you don't want to dig into this.

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Nov 19, 2024
@fsteeg fsteeg removed their request for review November 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants