Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MetaDrive support on macOS #794

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable MetaDrive support on macOS #794

wants to merge 4 commits into from

Conversation

DhlinV
Copy link
Collaborator

@DhlinV DhlinV commented Jan 6, 2025

What changes do you make in this PR?

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

Copy link
Member

@QuanyiLi QuanyiLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. The only change could be done is that using is_mac() to determine when the anisotrophic degree should be 1, 8 or 4 is needed for other platforms.

@QuanyiLi
Copy link
Member

QuanyiLi commented Jan 7, 2025

Please fix the test before merging. Also, I found the depth camera is unavailable, as the compute shader requires openGL>4.3. This affects not only MacOS but other platforms with lower GL versions.

We should consider implementing a new depth camera

@QuanyiLi
Copy link
Member

QuanyiLi commented Jan 7, 2025

I also found the failed test is due to the DepthCamera. Just ignore it and let's fix it in next PR

@pengzhenghao
Copy link
Member

The failed test might due to the depth cam... The Github CI has some problems when you run two tests on depth cam... So just ignore those tests for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants