Call destroy functions for all sensors, fix depth cam bug #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuanyiLi Any idea on the failed test here? Seems sth from engine |
|
My guess is |
|
Same issue here: #709 (comment) |
pengzhenghao
changed the title
# Conflicts: # metadrive/tests/test_sensors/test_simgen.py
pengzhenghao
changed the title
|
Seems caused by the github CI server's wierd GPU setting (some posts say you can't run it with integrated GPU). I don't want to waste time investigating this if it works in my PC and headless remote server. |
|
I'll close this PR as it's so frasutrating to study this. |
auto-merge was automatically disabled
December 17, 2024 20:47
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes do you make in this PR?
We will resolve #709 if the test passes here.
Checklist
bash scripts/format.shbefore merging.