Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize + dockerize tests #619

Closed
wants to merge 12 commits into from
Closed

Conversation

jnewb1
Copy link
Contributor

@jnewb1 jnewb1 commented Jan 25, 2024

What changes do you make in this PR?

Test other python versions to ensure they don't break, with the goal of supporting 3.12 soon (when some other packages support 3.12)

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@jnewb1 jnewb1 changed the title 3.12 Support Python 3.12 Jan 25, 2024
@jnewb1 jnewb1 marked this pull request as draft January 25, 2024 20:54
@jnewb1 jnewb1 changed the title Support Python 3.12 test python 3.9-3.11 Jan 25, 2024
@jnewb1 jnewb1 changed the title test python 3.9-3.11 test python 3.9-3.11 + try to support 3.12 Jan 25, 2024
@jnewb1 jnewb1 changed the title test python 3.9-3.11 + try to support 3.12 parameterize tests to support testing more python versions Jan 25, 2024
@jnewb1 jnewb1 changed the title parameterize tests to support testing more python versions parameterize + dockerize tests Jan 26, 2024
@pengzhenghao
Copy link
Member

Thank you for initiating this PR! What can I do for you? Is it now supporting newer python version or preparing a docker?

@jnewb1
Copy link
Contributor Author

jnewb1 commented Jan 30, 2024

Thank you for initiating this PR! What can I do for you? Is it now supporting newer python version or preparing a docker?

for now just preparing docker images so we can test multiple python versions. 3.12 has some dependency issues, I believe ray being one of them

@QuanyiLi
Copy link
Member

Is there anything I can do to help?

@jnewb1
Copy link
Contributor Author

jnewb1 commented Feb 6, 2024

one this is that it seems the docstring commenter is broken for forks
https://github.com/metadriverse/metadrive/actions/runs/7731719043/job/21080032902?pr=619

@QuanyiLi
Copy link
Member

QuanyiLi commented Feb 6, 2024

@pengzhenghao As you made the docstring commenter, could you take a look at this? I am not familiar with this..

@pengzhenghao
Copy link
Member

sure! I just removed the docstring commenter.

@jnewb1 jnewb1 closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants