concat no longer refers to itself causing infinite call loop

meszaros-lajos-gyorgy · May 20, 2021 · 3d6fef8 · 3d6fef8
1 parent 123c0ed
commit 3d6fef8
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/A.php b/src/A.php
@@ -349,8 +349,20 @@ public static function pickRandom(array $data)
     }
 
     // A::concat([1, 2], 3, [4, 5]) -> [1, 2, 3, 4, 5]
-    public static function concat(...$args): array {
-        return self::unnest(self::map(fn($arg) => self::ensureArray($arg),$args));
+    public static function concat(...$args): array
+    {
+        return self::reduce(
+            function ($acc, $arg) {
+                if (self::isArray($arg) && !self::isAssoc($arg)) {
+                    $acc = array_merge($arg, $acc);
+                } else {
+                    $acc[] = $arg;
+                }
+                return $acc;
+            },
+            [],
+            $args
+        );
     }
 
     // A::zipObj(['a', 'b'], [1, 2]) -> {a:1, b:2}