Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maturin v1.7.7-beta.1 for Windows build #67

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

messense
Copy link
Owner

No description provided.

@davidhewitt
Copy link

NB you'll want to set #[pymodule(gil_used = false)] to make the free-threaded wheel not accidentally re-enabled the GIL.

@messense
Copy link
Owner Author

GIL is acquired here to call Python callbacks so I guess it should not set gil_used = false?

nh3/src/lib.rs

Lines 158 to 160 in 89b8b1e

cleaner.attribute_filter(move |element, attribute, value| {
Python::with_gil(|py| {
let res = callback.call(

@davidhewitt
Copy link

That API is now a bit misleading, it's fine, that won't actually enable the GIL. See PyO3/pyo3#3987

@davidhewitt
Copy link

You only need to worry about stuff like unsafe impl Sync for MyStruct {} where you rely on the GIL for the thread-safety. Otherwise PyO3 has you covered :)

@messense messense changed the title Use maturin v1.7.6-beta.1 for Windows build Use maturin v1.7.7-beta.1 for Windows build Nov 29, 2024
@messense messense merged commit c1bb436 into main Nov 29, 2024
15 checks passed
@messense messense deleted the windows-maturin-beta branch November 29, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants