Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect.getargspec() is deprecated #192

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

broCapang
Copy link

Screenshot 2024-04-20 032907

An error occurred while playing with the examples.
in malaya\supervised\huggingface.py

---> 22 args = inspect.getargspec(class_model)

Apparently inspect.getargspec has been deprecated.
ref: pytorch/pytorch#15344

Changes

replace inspect.getargspec with inspect.getfullargspec

@huseinzol05
Copy link
Member

apa version python

@broCapang
Copy link
Author

apa version python

Python 3.11.4

@broCapang
Copy link
Author

Mintak follow up

@huseinzol05
Copy link
Member

u need to test on version python3.11 and below python3.11

@MagusWyvern
Copy link
Collaborator

This error only occurs on Python 3.11 and newer as inspect.getargspec() was removed in that version. While the modern solution is to use inspect.signature() I have doubts of it working on versions <3.11.

This implementation seems like a good workaround to the deprecation warnings while also being stable, nanti saya akan test pakai Python <3.11 ok atau tidak

@MagusWyvern MagusWyvern self-assigned this Aug 26, 2024
@MagusWyvern MagusWyvern added the bug Something isn't working label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants