Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AttributionControl to Map to comply with OSM license requirements #356

Merged

Conversation

danditomaso
Copy link
Contributor

Adds the attribution control to the Map page, as mentioned in the issue #348 this is a license requirement for using OpenStreetMap. The attribution was adding using a single line, and I re-used the darkMode variable to ensure custom style are applied so it would display correctly depending on the users light or dark mode preference.

image

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@danditomaso
Copy link
Contributor Author

Linking to #348

@fifieldt fifieldt merged commit 1087c68 into meshtastic:master Dec 29, 2024
2 of 3 checks passed
@danditomaso danditomaso deleted the add_attribution_control_to_map branch December 30, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants