Adds support for ble logging characteristic #616
Conversation
|
ooh this is super useful! |
|
btw - @thebentern no need for you to try and fix the build errors which were reported. (by coincidence) When I recently tried using --ble it seems to me that the old version of the "Bleak" BLE library that were using had problems now connecting to meshtastic devices (at least on linux). But the new/current version has a number of breaking API changes. My WIP branch to make the current Bleak work for us is here: https://github.com/geeksville/Meshtastic-python/tree/pr-fixbluetooth I'll finish that work up and send a PR in. Or if it is okay with you I can merge it into this PR? |
|
Sure! |
on linux breaks all but the first connection attempts. Also remove unneeded event stuff and arbitrary timeouts, better just to use thread.join()
|
@thebentern okay - fixes to make bleak work robustly again on Linux are in. Would you mind trying on OS-X to confirm I didn't break anything there? |
|
oops - I forgot to run pylint before submitting. fixing. |
|
btw: note: I added an optional --ble-dest flag to specify target device. --ble now takes no args and if no device is specified and we can only find one paired meshtastic device, we just use that. |
|
@geeksville I'm having some environment issues on my OS-X machine right now but it tested out fine on my Windows box, so I say ship it! |
It turns out that Bleak is kinda racey. If we call disconnect() and then immediately close() the disconnect may or may not actually happen (probably because it was merely queued for dbus). So instead: When we want to close the BLEInterface we call disconnect() and then in a preregistered 'on disconnect' handler we actually close down our interface/datastructures.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
==========================================
- Coverage 62.04% 61.92% -0.13%
==========================================
Files 14 14
Lines 3009 3015 +6
==========================================
Hits 1867 1867
- Misses 1142 1148 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
heh - I'm not sure how to fix the sentry thing. Because I kinda doubt that sentry had any real code coverage testing on the existing (buggier) BLE code ;-) |
# Conflicts: # poetry.lock
|
Nice, looks good to me! |
Closes #609
