DO NOT MERGE: instead, can we use this issue to discuss the idea of possibly using Poetry for builds? #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does anyone still use this old script besides me? It is kinda yucky and I think it needs this change to work with the new virtualenv hotness. Also: what do ya'll think about possibly switching to Poetry for our python builds? It is really nice (and apparently the new cool way to make projects for pypi) and hides the virtualenv goo. If you are interested I'm willing to send in a PR for your consideration. Would make the env for devs much easier I think - also nicely packages for pypi and removes the need for requirements.txt.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 61.94% 61.94%
=======================================
Files 14 14
Lines 2917 2917
=======================================
Hits 1807 1807
Misses 1110 1110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does anyone still use this old script besides me? It is kinda yucky and I think it needs this change to work with the new virtualenv hotness.
Also: what do ya'll think about possibly switching to Poetry for our python builds? It is really nice (and apparently the new cool way to make projects for pypi) and hides the virtualenv goo. If you are interested I'm willing to send in a PR for your consideration. Would make the env for devs much easier I think - also nicely packages for pypi and removes the need for requirements.txt.