Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added illuminance sensors value on the environmental sensors screen (lux and white_lux) #5801

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

isseysandei
Copy link
Contributor

Added lux and white_lux to the environment sensors screen

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ isseysandei
✅ thebentern
❌ BuildTools


BuildTools seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ isseysandei
❌ BuildTools


BuildTools seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@isseysandei isseysandei marked this pull request as ready for review January 9, 2025 17:53
@isseysandei
Copy link
Contributor Author

Hmmm what's happening here? Why is it failing now?
Also, can someone help me fixing the "buildtool didn't sign" warning?

@fifieldt
Copy link
Contributor

The formatting in src/modules/Telemetry/EnvironmentTelemetry.cpp
Doesn't match what is expected by our linting tool. If you install trunk in vscode it should take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants