Add support for new NRF52 board, MeshLink #5736
Conversation
| #ifdef PIN_3V3_EN | ||
| digitalWrite(PIN_3V3_EN, LOW); | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
What is the reason behind this? i am asking because maybe we already have a way to accomodate this without the macro guards.
There was a problem hiding this comment.
I used the PIN_3V3_EN definition for the watchdog enable pin, because i needed a pin that would have been turned off automatically by the firmware when we put the cpu to sleep with button longpress. Otherwise, the watchdog would remain enabled without being reset by the status led blink (because the cpu is sleeping). I could rename it to WD_EN and add a specific digitalwrite for my board in main-nrf52.cpp and src/sleep.cpp. I just noticed that there could also be an edge case scenario problem when using repeater role as 3v3_en pin would be disabled on startup
https://github.com/ponzano/MeshLink/blob/c82f23ed2aa81cb09ba4e57e281347da74e02cb0/src/main.cpp#L649C5-L649C121
| #define PIN_A0 (2) | ||
| #define PIN_A7 (31) | ||
| /* | ||
| static const uint8_t A0 = PIN_A0; |
There was a problem hiding this comment.
Please remove the RAK4631 specific comments. These will confuse developers working on this define.
|
|
||
| */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
see above, this comment is RAK specific and actually wrong for the ebyte module you are using.
|
Also please run trunk fmt before you commit |
looks like i have some work to do, thank you for the help ! :) |
|
Paolo Ponzano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Huh?? That’s weird.. anyway sorry for the mess, I’ll avoid committing again until everything is done 😥 |
Hi everyone, in the past year i've been developing a new board to use with meshtastic and i'd like to have it supported officially by the firmware. I started by making a google form to ask what the local community would have liked to have on a new device and then worked on trying to make it come true. We have been testing the prototypes for some months now and i will soon have a new batch produced with fixes and improvements. It was developed to satisfy both remote location and daily portable use cases, while trying to keep costs low. Please keep in mind that i'm just a student and this is basically my first time designing a pcb, but it works and i'm open to constructive criticism.
A little list of specs (will do a more complete datasheet asap):
50x70mm footprint and mounting holes corresponding to common 50x70 perfboard, NRF52840, eByte E22900M22S (Will also come with other frequencies), MPPT solar charger with selectable and adjustable voltage 5v,12v,18v; support for gps, buzzer, oled or e-ink display, 10 gpios, hardware watchdog, integrated INA219, extra flash memory.
Let me know if some edits to the PR or code need to be made :)
Please note that these are pictures of the prototypes and final product will be slightly different, although ports placement and general size are the same