Add node name below traceroute node circles #966
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Proposing adding the long node name below the node circles in the tracroute view. This change adds
some missing traceRouteHop name assignments and then adds the name string below the node
circle and above the snr string.
Why did it change?
Currently neither the node's short nor long name are part of circular traceroute view. This leverages the
fact that the name is already available to the view and adds it in the same way other node circle names
are represented elsewhere in the app.
How is this tested?
Ran various traceroute iterations and saw that the name was being shown under the circles in the circular
traceroute display.
Screenshots/Videos (when applicable)
Checklist