Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node name below traceroute node circles #966

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Oct 13, 2024

What changed?

Proposing adding the long node name below the node circles in the tracroute view. This change adds
some missing traceRouteHop name assignments and then adds the name string below the node
circle and above the snr string.

Why did it change?

Currently neither the node's short nor long name are part of circular traceroute view. This leverages the
fact that the name is already available to the view and adds it in the same way other node circle names
are represented elsewhere in the app.

How is this tested?

Ran various traceroute iterations and saw that the name was being shown under the circles in the circular
traceroute display.

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@powersjcb
Copy link
Contributor

Could you attach a screenshot for reference showing how this renders in the UI?

@@ -869,6 +869,7 @@ class BLEManager: NSObject, CBPeripheralDelegate, MqttClientProxyManagerDelegate
traceRoute?.hasPositions = true
}
}
traceRouteHop.name = hopNode?.user?.longName ?? "Unknown"
Copy link
Contributor

@powersjcb powersjcb Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this overriding an existing traceRouteHop.name value or is this populating an empty field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is currently not used.
I was a bit torn with this one. Without a data model update, we have one name. That could be used for the short name, to correct the name inside the circle. Otherwise, there is this option, to add the long name under the circle.

@bjpetit
Copy link
Contributor Author

bjpetit commented Oct 22, 2024

Here's an example.
IMG_0524 (1)

@bjpetit bjpetit marked this pull request as draft November 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants