Refactor App Routing & Navigation API's #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72A12F4E
commented
Jul 11, 2024
72A12F4E
commented
Jul 11, 2024
72A12F4E
commented
Jul 11, 2024
72A12F4E
commented
Jul 11, 2024
72A12F4E
force-pushed
the
app-routing
branch
2 times, most recently
from
eb8949d to
228d1d9
Compare
72A12F4E
changed the title
thebentern
reviewed
Jul 14, 2024
…ough a Router to improve how deep link URLs are handled
…t at the app root instead
|
On the messages tab I am not seeing the messaging pane updating properly in catalyst when selecting a contact for a DM, otherwise everything seems to match what is working currently, it is working on a phone. |
fixed in latest |
garthvh
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
This change is a substantial refactor that changes how app routing and navigation state is handled across the app. I've introduced a new type,
Router, that is the single source of truth for where the user is in the app. Navigation APIs in Messages, Nodes, and Settings were refactored to utilize the newRoutertype.How is this tested?
I've added a unit test target to the app that validates several deep link URL's map to the appropriate routes, and done manual validation across two nodes & two client devices to send notifications back & forth.
Next Steps?
We still need to implement routing on the Map views to handle Waypoint notifications. We could also improve the map focus for map routing, but these can be done in a follow-up change.