Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localizable.xcstrings #1044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

HJen-git
Copy link

@HJen-git HJen-git commented Jan 4, 2025

Replaced incorrect german translation in 2 locations Old: key -> Taste (meaning key as in keyboard)
New: key -> Schlüssel (meaning key as in access key)

What changed?

Resource entries for 2 german localizations.
Location in app: Settings for channel encryption, key and key length/size.

Line 31336 is an unexpected change and should be omitted.

Why did it change?

The previous translation made no sense in that context.
The english word key was translated to german as a key you find on a keyboard or piano, but in this context an access/encryption key is meant. The correct translation for such a key is "Schlüssel" as in "Zugangsschlüssel" and "Schlüssellänge"

How is this tested?

Test correct display of the umlaut (there was already one present, so no problem expected) and for cropping/line break through length.

Screenshots/Videos (when applicable)

n/a

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • [n/a] I have commented my code, particularly in complex areas.
  • [n/a] I have made corresponding changes to the documentation.
  • [-] I have tested the change to ensure that it works as intended.

Replaced incorrect german translation in 2 locations
Old: key -> Taste (meaning key as in keyboard)
New: key -> Schlüssel (meaning key as in access key)
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HJen-git
Copy link
Author

HJen-git commented Jan 5, 2025

I noticed a lot of missing translation strings as well.
I don't have any non-solo experience with git yet, but if the way I submitted is sufficient I would like to add any missing translations I find.
I mainly noticed missing strings for signal strength, device modes, status/error codes, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants