Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Removed OAM #227

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[chore] Removed OAM #227

wants to merge 5 commits into from

Conversation

acald-creator
Copy link
Contributor

@acald-creator acald-creator commented Apr 20, 2023 •
edited
Loading

Description

This PR:

  • Update meshery-adapter-library and meshkit
  • Remove OAM configuration to use MeshModel directly
  • Fix minor misspelling
  • Turned on debug in logger
  • The NGINX Service Mesh's version is hardcoded and will needs to be changed to be declared in a variable. NGINX Service Mesh have moved away from downloading releases from the GitHub Releases, it looks like, and now you would download the raw file from within the repo itself. Their versioning has changed as well.

See repo: https://github.com/nginxinc/helm-charts/tree/master/stable

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 9, 2023
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Jul 9, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/willfix This issue will be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acald-creator @leecalcote